status/network: Update indicator icon on connectivity changes

When there is no active main connection or it uses a device type we do
not handle, the indicator icon and its visibility depend on the global
connectivity.

However we currently don't update the icon on connectivity changes,
with the result that we sometimes show the fallback connection icon
when the network is in fact disconnected.

To fix this, update the icon whenever the (global) connectivity changes.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7357
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8549
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3910>

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index d4903a11c4deb92d34166d559af1237136c9c344..6cf195d4178e85d1bd668824bb11b7b890b2a7eb 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -2199,7 +2199,6 @@ class Indicator extends SystemIndicator {
             this._mainConnectionStateChanged();
         }
 
-        this._updateIcon();
         this._syncConnectivity();
     }
 
@@ -2209,6 +2208,7 @@ class Indicator extends SystemIndicator {
     }
 
     _syncConnectivity() {
+        this._updateIcon();
         if (this._mainConnection == null ||
             this._mainConnection.state !== NM.ActiveConnectionState.ACTIVATED) {
             this._portalHandler.clear();